-
Notifications
You must be signed in to change notification settings - Fork 127
Add KillCaller feature to test server for CLI crash recovery testing #4146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KillCaller feature to test server for CLI crash recovery testing #4146
Conversation
89e1011 to
3a3b6f5
Compare
|
@denik could you please review this pr |
debc6c8 to
bcc288c
Compare
bcc288c to
ba053c3
Compare
|
@denik can you please queue the integration tests |
|
@denik bump ^^ |
|
Commit: 1739962
24 interesting tests: 21 KNOWN, 2 FAIL, 1 SKIP
Top 25 slowest tests (at least 2 minutes):
|
Signed-off-by: Varun Deep Saini <[email protected]>
|
@denik Had a few questions,
|
Signed-off-by: Varun Deep Saini <[email protected]>
That's a good idea.
yes. simple mutex would work.
I was thinking of more general request matcher that can match requests based on payload substring. Then we won't need predefined sequence and also be more reliable in case of unexpected retries. |
|
@denik I can add another field for the regex string, and kill all the requests which have the body matching that regex does that work with what idea you had ? (i would still like to keep the int field as well, for easier use) |
In this PR, let's keep your counter approach. Body matching is just an idea for a separate feature. |
|
@denik bump ^^ |
denik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
|
@denik |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
@varundeepsaini I noticed the new tests are flaky on my laptop. Could you check if can repro and perhaps you know what could be the reason? |
|
Checking |
|
Commit: a0aa88c
29 interesting tests: 17 KNOWN, 5 FAIL, 4 RECOVERED, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Closes: #4140
Changes
Add
KillCalleroption to test server that terminates the CLI process when specific endpoints are hit. This enables testing crash recovery scenarios likebundle deployinterrupted mid-execution.KillCallerspecifies how many times to kill before allowing normal responses, enabling retry/recovery testing.Why
Enables testing CLI crash recovery scenarios (e.g.,
bundle deployinterrupted mid-execution).Tests
Added
acceptance/selftest/kill_caller/tests.